Project

General

Profile

Bug #10925

noiseprofiles naming problem

Added by martin barinka almost 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
02/20/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0.1
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

hi

I made sample images to make profile for K-S2.
I used script gen-profiles and thes started darktable with darktable --noiseprofile presets.json but no profiles was present in plugin
darktable out
[noiseprofile] loading noiseprofiles from `/home/martin/Obrázky/out/100_1902/presets.json'
[noiseprofile] verifying noiseprofile file
[noiseprofile] found 1 makers
[noiseprofile] found maker `Ricoh'
[noiseprofile] found 1 models
[noiseprofile] found PENTAX K-S2
[noiseprofile] found 144 profiles
[noiseprofile] verifying noiseprofile completed
[iop_load_module] loading iop `denoiseprofile' from /usr/lib/darktable/plugins/libdenoiseprofile.so
[noiseprofile] looking for maker `Pentax', model `K-S2'
[noiseprofile] found 1 makers

it is looking for maker `Pentax', model `K-S2' but in that json is "maker": "Ricoh" "model": "PENTAX K-S2"

i added exiftool dump from one image

exif (10.7 KB) exif exiftool dump from one image martin barinka, 02/20/2016 12:05 PM

Associated revisions

Revision 8aae2406 (diff)
Added by Pedro Côrte-Real almost 4 years ago

tools: handle Pentax naming in gen-profile

Newer Pentax cameras have "Ricoh" as Maker and "Pentax <model>"
as the model name. Set the make/model to "Pentax"/"<model>" in
those cases to match what we actually use.

The full fix for this would be to just use the exif make/model
and do a lookup in cameras.xml. There's Ruby code to do that in
tools/check_camera_support but it would require either depending
on ruby for gen-profile or doing something equivalent in shell.

Fixes #10925

History

#1 Updated by Pedro Côrte-Real almost 4 years ago

  • Status changed from New to Closed: won't fix

Manufacturers name their cameras in all sorts of weird ways. Sometimes that means doing a little manual editing to get everything working properly. Once you do that all the naming everywhere becomes consistent and it allows you to do things like call all Pentax cameras "Pentax" in the interface instead of a mix of Pentax/Ricoh/RICOH/PENTAX and have a proper camera support matrix. This is particularly important in this case because there are cameras that users know as Ricoh (e.g., the GR) and as Pentax, so there's no automatic way of doing the right thing.

#2 Updated by Roman Lebedev almost 4 years ago

The script does use darktable-cli to export the raw file: https://github.com/darktable-org/darktable/blob/0fb9d7c/tools/noise/gen-profile#L129
That means, the raw is opened through rawspeed => the correct values for maker and model are known.
Why can't it then use those correct values, and not those from exiv2 https://github.com/darktable-org/darktable/blob/42cd9c6/tools/noise/subr.sh#L315-L324 ?

#3 Updated by Pedro Côrte-Real almost 4 years ago

darktable-cli doesn't output the clean names anywhere, maybe it should. I've pushed a simple fix for this case and a full fix would be easy by just using the code that already exists in tools/check_camera_support to parse cameras.xml and produce the EXIF->ID map. The only issue with using that code is that it would add a ruby dependency to tools/gen-profile.

#4 Updated by Pedro Côrte-Real almost 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Closed: won't fix to Fixed

#5 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top