Project

General

Profile

Bug #10916

build error on Debian 8 with commit 5e9ada4ce7c946fb986d60fee316cd628aec3f46

Added by Christian Kanzian over 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Category:
Map / Geolocation
Target version:
Start date:
02/17/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,

Current git version doesn't build on my Debian 8 system after commit 5e9ada4ce7c946fb986d60fee316cd628aec3f46. Build log is attached.


/home/chri/Linux/darktable/src/views/map.c: In function ‘_view_map_center_on_bbox’:
/home/chri/Linux/darktable/src/views/map.c:847:3: error: implicit declaration of function ‘osm_gps_map_zoom_fit_bbox’ [-Werror=implicit-function-declaration]
   osm_gps_map_zoom_fit_bbox(lib->map, lat1, lat2, lon1, lon2);
   ^
/home/chri/Linux/darktable/src/views/map.c: At top level:
/home/chri/Linux/darktable/src/views/map.c:903:8: error: unknown type name ‘OsmGpsMapPolygon’
 static OsmGpsMapPolygon *_view_map_add_polygon(const dt_view_t *view, GList *points)
        ^
/home/chri/Linux/darktable/src/views/map.c: In function ‘_view_map_add_polygon’:
/home/chri/Linux/darktable/src/views/map.c:907:3: error: unknown type name ‘OsmGpsMapPolygon’
   OsmGpsMapPolygon *poly = osm_gps_map_polygon_new();
   ^
/home/chri/Linux/darktable/src/views/map.c:907:3: error: implicit declaration of function ‘osm_gps_map_polygon_new’ [-Werror=implicit-function-declaration]
/home/chri/Linux/darktable/src/views/map.c:907:28: error: initialization makes pointer from integer without a cast [-Werror]
   OsmGpsMapPolygon *poly = osm_gps_map_polygon_new();
                            ^
/home/chri/Linux/darktable/src/views/map.c:920:3: error: implicit declaration of function ‘osm_gps_map_polygon_add’ [-Werror=implicit-function-declaration]
   osm_gps_map_polygon_add(lib->map, poly);
   ^
/home/chri/Linux/darktable/src/views/map.c: At top level:
/home/chri/Linux/darktable/src/views/map.c:925:65: error: unknown type name ‘OsmGpsMapPolygon’
 static gboolean _view_map_remove_polygon(const dt_view_t *view, OsmGpsMapPolygon *polygon)
                                                                 ^
/home/chri/Linux/darktable/src/views/map.c: In function ‘_view_map_remove_marker’:
/home/chri/Linux/darktable/src/views/map.c:976:5: error: implicit declaration of function ‘_view_map_remove_polygon’ [-Werror=implicit-function-declaration]
     case MAP_DISPLAY_POLYGON: return _view_map_remove_polygon(view, OSM_GPS_MAP_POLYGON(marker));
     ^
/home/chri/Linux/darktable/src/views/map.c:976:5: error: implicit declaration of function ‘OSM_GPS_MAP_POLYGON’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
src/views/CMakeFiles/map.dir/build.make:54: recipe for target 'src/views/CMakeFiles/map.dir/map.c.o' failed
make[2]: *** [src/views/CMakeFiles/map.dir/map.c.o] Error 1
CMakeFiles/Makefile2:1442: recipe for target 'src/views/CMakeFiles/map.dir/all' failed
make[1]: *** [src/views/CMakeFiles/map.dir/all] Error 2
make[1]: *** Warte auf noch nicht beendete Prozesse...
Scanning dependencies of target slideshow
[ 55%] Building C object src/views/CMakeFiles/slideshow.dir/slideshow.c.o
Linking C shared module libdarkroom.so
[ 55%] Built target darkroom
Linking C shared module libslideshow.so
[ 55%] Built target slideshow
Linking C shared module liblighttable.so
[ 55%] Built target lighttable
Makefile:137: recipe for target 'all' failed
make: *** [all] Error 2

Christian

build.log (33.1 KB) build.log Christian Kanzian, 02/17/2016 09:54 AM

History

#1 Updated by Roman Lebedev over 4 years ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed
  • Category changed from General to Map / Geolocation

8 == stable => osm-gps-map version is 1.0.2-2

#2 Updated by Tobias Ellinghaus over 4 years ago

  • % Done changed from 10 to 50
  • Assignee set to Tobias Ellinghaus
  • Status changed from Confirmed to In Progress

Sorry, that was me. I assumed that the libosmgpsmap docs were consistent in mentioning the release that added new API, but for these things it didn't say anything, so i thought it was safe to use. I'll try to sprinkle a bunch of #ifdef over the code.

#3 Updated by Tobias Ellinghaus over 4 years ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

#4 Updated by Christian Kanzian over 4 years ago

Yes, it's fixed now.

Thanks!

#5 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top