Project

General

Profile

Feature #10890

Complex Text Layout

Added by Asma AL-Bahanta about 4 years ago. Updated about 4 years ago.

Status:
Incomplete
Priority:
Low
Assignee:
-
Category:
General
Target version:
-
Start date:
01/25/2016
Due date:
% Done:

20%

Estimated time:
Affected Version:
git development version
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,
I have been modifying darktable code to so that it uses Pango for text layout to support languages that require complex text layout
such as Arabic, Hebrew, and Indic language.However, I have been able to modify and test some files such as lighttable.c, atrous.c, lowlight.c and tonecurve.c and they have been merged already but there are files where I could not test (due to my limited knowledge in darktable o_o; ). I would appreciate your help in guiding me how I can generate and test the functionalities in the following files:
1)clipping.c:
Lines :2124, 2196, 2267 and 2478.

2)camera.c:
Lines: 349, 357 and 377.

History

#1 Updated by Tobias Ellinghaus about 4 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

I am not sure what you mean. I guess changing the code is straight forward as it's basically the same as you already handled in other places. So do you just want to know where to see those strings in the GUI? In that case, clipping.c is "crop & rotate" in darkroom and the lines in camera.c are the top black bar in the center view of tethering. You need a (supported) camera attached to enter that.

#2 Updated by Asma AL-Bahanta about 4 years ago

Tobias Ellinghaus wrote:

I am not sure what you mean. I guess changing the code is straight forward as it's basically the same as you already handled in other places. So do you just want to know where to see those strings in the GUI? In that case, clipping.c is "crop & rotate" in darkroom and the lines in camera.c are the top black bar in the center view of tethering. You need a (supported) camera attached to enter that.

yes, that's what I meant. I made a pull request for the changes and I was unable to test these files :
camera.c
navigation.c
view.c
control.c
I hope you can test these files and tell me if there is a problem especially in their positions :).
Here is the pull request url in github: https://github.com/darktable-org/darktable/pull/1127

Thank you in advance.

Also available in: Atom PDF

Go to top