Project

General

Profile

Bug #10881

SIGSEGV when opening images (liquify branch)

Added by Philipp Christ about 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Critical
Assignee:
Pascal Obry
Category:
Darkroom
Target version:
2.2.0
Start date:
01/17/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

DT crashes here when opening images.

For now it looks like almost all the crashes happened if the mouse is moving over the drawing area while the image is still loading.

A few backtraces are attached.

this is darktable 2.1.0+161~geedd729
copyright (c) 2009-2015 johannes hanika

compile options:
normal build
OpenMP support enabled
OpenCL support enabled
Lua support enabled, API version 3.0.0
Colord support enabled
gPhoto2 support enabled
GraphicsMagick support enabled

I couldn't reproduce it on my last installed master build (2.1.0+84~g5b8862f).

If you need anything or i can test something just give me a shout.

darktable_bt_ALQ1AY.txt (33.3 KB) darktable_bt_ALQ1AY.txt Philipp Christ, 01/17/2016 10:22 PM
darktable_bt_97LCBY.txt (33.2 KB) darktable_bt_97LCBY.txt Philipp Christ, 01/17/2016 10:22 PM
darktable_bt_NZVIBY.txt (36.5 KB) darktable_bt_NZVIBY.txt Philipp Christ, 01/17/2016 10:22 PM
dt_liq_orientation_bug_02.jpg (101 KB) dt_liq_orientation_bug_02.jpg one line one curve Philipp Christ, 01/21/2016 12:09 AM

Associated revisions

Revision 4cb3d921 (diff)
Added by Pascal Obry about 4 years ago

Lock and copy the pipe data in get_point_scale()

It is not safe to use a pipe in a GUI thread. Using a copy in this
case should fix reported crashes see #10881.

Revision 54570e67 (diff)
Added by Pascal Obry about 4 years ago

Lock and copy the pipe data in get_point_scale()

It is not safe to use a pipe in a GUI thread. Using a copy in this
case should fix reported crashes see #10881.

Revision 3a7c0fba (diff)
Added by Pascal Obry about 4 years ago

Lock and copy the pipe data in get_point_scale()

It is not safe to use a pipe in a GUI thread. Using a copy in this
case should fix reported crashes see #10881.

Revision 23b604b1 (diff)
Added by Pascal Obry about 4 years ago

Lock and copy the pipe data in get_point_scale()

It is not safe to use a pipe in a GUI thread. Using a copy in this
case should fix reported crashes see #10881.

Revision bac3024d (diff)
Added by Pascal Obry about 4 years ago

Lock and copy the pipe data in get_point_scale()

It is not safe to use a pipe in a GUI thread. Using a copy in this
case should fix reported crashes see #10881.

History

#1 Updated by Roman Lebedev about 4 years ago

  • Assignee set to Pascal Obry

#2 Updated by Pascal Obry about 4 years ago

This is a know issue that has already been fixed. So no surprise it cannot be reproduced on master.

#3 Updated by Pascal Obry about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

Ok, let me close this ticket. Just reopen if the issue is still there.

#4 Updated by Roman Lebedev about 4 years ago

  • % Done changed from 100 to 10
  • Priority changed from Low to Critical
  • Status changed from Fixed to Confirmed

#5 Updated by Pascal Obry about 4 years ago

I have a version that should avoid this crash. Philipp can you test it?

#6 Updated by Pascal Obry about 4 years ago

  • % Done changed from 10 to 50
  • Status changed from Confirmed to In Progress

#7 Updated by Philipp Christ about 4 years ago

Well, the good news is, even with trying for a while, I can no longer reproduce the crash on 3a7c0fba.

The bad news is that now, with orientation active, the position is no longer translated from the correct coordinates. (see screenshot)
The vectors still seem to work in the right direction, just the node coordinates seem to be 90 degrees off.

Also, in all tests so far i have had the odd line/curve like in the attached screenshot, where the affected area would just stay black after drawing and sometimes after opening the image. Zooming/Moving the viewpoint usually fixes this.

#8 Updated by Pascal Obry about 4 years ago

Hum... no longer translated, are you sure this has been working at some point?

#9 Updated by Pascal Obry about 4 years ago

Ok, found the issue and fixed it. Can you try again? Thanks.

#10 Updated by Philipp Christ about 4 years ago

Everything seems to be in the right place now. Still no crashes either.

#11 Updated by Pascal Obry about 4 years ago

Great! I'm planning for a merge tomorrow. This has been reviewed and tested by different people at this point.

Thanks a lot for the testing and feedbacks. Very much appreciated.

#12 Updated by Pascal Obry about 4 years ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

#13 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top