Project

General

Profile

Bug #10822

typo in noiseprofiles.json

Added by Philippe Kueck about 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
12/27/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0.0
System:
Fedora/RHEL
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,

a typo in noiseprofiles.json at line 1707 makes darktable 2.0 ignore all other denoising profiles for the Nikon D5200 except for iso 100 :)

--- noiseprofiles.json.bak
+++ noiseprofiles.json
@@ -1682,7 +1682,7 @@
           "profiles": [
             {"name": "Nikon D5200 iso 100", "iso": 100, "a": [8.44357279975327e-06, 2.87700239498207e-06, 4.71471435241959e-06], "b": [-1.59851390906603e-07, -9.45056675364089e-08, -2.59836013503805e-08]},
             {"skip": true, "name": "Nikon D5200 iso 100", "iso": 100, "a": [8.44284597322115e-06, 2.88355825192422e-06, 4.70775411918953e-06], "b": [-1.52816724559017e-07, -9.48224045041411e-08, -2.66070728441539e-08]},
-            {"na me": "Nikon D5200 iso 125", "iso": 125, "a": [1.00323452391988e-05, 3.46787255715821e-06, 5.62832925371119e-06], "b": [-1.55926360262396e-07, -1.06216898381974e-07, -1.81779226997151e-08]},
+            {"name": "Nikon D5200 iso 125", "iso": 125, "a": [1.00323452391988e-05, 3.46787255715821e-06, 5.62832925371119e-06], "b": [-1.55926360262396e-07, -1.06216898381974e-07, -1.81779226997151e-08]},
             {"skip": true, "name": "Nikon D5200 iso 125", "iso": 125, "a": [1.00341033991099e-05, 3.48316263555564e-06, 5.64563888648967e-06], "b": [-1.58235349561254e-07, -1.0758864758329e-07, -1.99377348679036e-08]},
             {"name": "Nikon D5200 iso 160", "iso": 160, "a": [1.19100294653547e-05, 4.10697591702703e-06, 6.76408915222684e-06], "b": [-1.48249873424569e-07, -9.72132672258075e-08, 4.72049690531132e-10]},
             {"skip": true, "name": "Nikon D5200 iso 160", "iso": 160, "a": [1.19088656164533e-05, 4.14540941684071e-06, 6.75949093063126e-06], "b": [-1.40551096093225e-07, -1.07846903665761e-07, 2.27332694441256e-09]},

Kind regards

Philippe

denoise.png (28.4 KB) denoise.png Philippe Kueck, 12/27/2015 08:55 PM

Associated revisions

Revision 52ae2491 (diff)
Added by Pedro Côrte-Real about 4 years ago

noiseprofiles: fix typo in D5200 profile

Thanks to Philippe Kueck for the patch.
(fixes #10822)

Revision 157d970b (diff)
Added by Pedro Côrte-Real about 4 years ago

noiseprofiles: fix typo in D5200 profile

Thanks to Philippe Kueck for the patch.
(fixes #10822)

Revision 388d93d2 (diff)
Added by Tobias Ellinghaus about 4 years ago

Validate noiseprofiles.json on startup

... so that something like bug #10822 won't happen again.

Revision 41e95dda (diff)
Added by Tobias Ellinghaus about 4 years ago

Validate noiseprofiles.json on startup

... so that something like bug #10822 won't happen again.

(cherry picked from commit 388d93d2164a6d519aae51dbc9f34baa0affa939)

History

#1 Updated by Pedro Côrte-Real about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#2 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top