Project

General

Profile

Bug #10771

spot removal circle not working

Added by Pascal Obry over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Critical
Assignee:
-
Category:
Darkroom
Start date:
12/11/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Just found out that the spot removal circle tool does not work anymore.

When you click on the image you see a single circle which is the target area but there is no source visible. Moreover there the transparency seems to be the one from the last mask.

The ellipsis and polygon tools are fine.

Associated revisions

Revision 16e7495a (diff)
Added by Ulrich Pegelow over 3 years ago

circel shape: set a lower limit for number of shape points

avoids small circle shapes to not being displayed; this might fix #10771

History

#1 Updated by Pascal Obry over 3 years ago

  • Category set to Darkroom

#2 Updated by Ulrich Pegelow over 3 years ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed

I kinda confirm. If one shrinks the circle more and more, at some point the shape is no longer displayed properly: the source area is invisible and the target gets only displayed if the mouse pointer is over the shape. Unfortunately, once this state is reached all following new circles have the same problem as they get their parameters from darktablerc which has stored the last circle's settings. Only option to recover right now seems to be manually editing darktablerc.

#3 Updated by Ulrich Pegelow over 3 years ago

I have just pushed a fix to master which prevents small circle shapes from being displayed. You might still need to edit darktablerc in order to recover your current situation (set plugins/darkroom/spots/circle_border and plugins/darkroom/spots/circle_border to something like 0.1).

#4 Updated by Ulrich Pegelow over 3 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

#5 Updated by Ulrich Pegelow over 3 years ago

  • % Done changed from 100 to 50
  • Status changed from Fixed to In Progress

The robot might be a bit too optimistic. Let's wait for feedback before we call this issue fixed.

#6 Updated by Pascal Obry over 3 years ago

I've debugged a bit this issue. I found that this is bad interaction with stored values.
Removing the 3 following lines for spot removal in .config/darktable/darktablerc fixes the issue:

plugins/darkroom/spots/circle_border=0.093081153929233551
plugins/darkroom/spots/circle_size=0.0018725015688687563
plugins/darkroom/spots/size=0.048569392412900925

#7 Updated by Pascal Obry over 3 years ago

Forgot to say that darktable|16e7495ae2d97163d4bc6ebe8ad9e6d645112f77 did not fix the issue for me.

#8 Updated by Ulrich Pegelow over 3 years ago

As I wrote the issue has probably been introduced when you reduced the spot size of one of the circles during work. darktable stores the last value in plugins/darkroom/spots/circle_size for convenience reasons. This way you get the same circe size if you go to fix another spot.

Before commit 16e7495ae2d97163d4bc6ebe8ad9e6d645112f77 darktable would not properly display the outlines of the circle if the size was getting too small. This would effectively prevent any further edits and also not allow you to grow the spot size again.

At least here everything is functional with commit 16e7495ae2d97163d4bc6ebe8ad9e6d645112f77 even if I put the values from posting 6 into my darktablerc - new spots are created with a very small size but they act as expected and can be edited.

#9 Updated by Ulrich Pegelow over 3 years ago

Anything more to do here?

#10 Updated by Pascal Obry over 3 years ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

No, should be closed now. Thanks!

Also available in: Atom PDF

Go to top