Project

General

Profile

Bug #10743

Elliptic mask "external shape" should be proportional to the "internal shape"

Added by Guillaume Subiron about 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Category:
Masks
Target version:
Start date:
11/27/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0rc2
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I don't know if I'm very clear, but I will try to explain my problem with a use case. I am trying to add (or at least to increase) the sun in the picture. To do that, I use the elliptic mask and increase the luminosity (I also add yellow in color correction, but it doesn't matter). The idea is that the mask should be more feathered horizontaly than verticaly. Do you see what I mean?

I believe the attachment explains quite well the problem I get when I try to add the sun with an elliptic mask. The mask is really flat, but the global shape (with the feathering) is not proportional, so the global mask became to much large. It become more and more anoying as I decrease the "internal size" of the mask, and increase it's "external size".

Of course, I'm aware that this request rises some backward compatibility problem. Maybe you have some suggestions to fix it?

2015-11-27-175518_1920x2100_scrot.png (805 KB) 2015-11-27-175518_1920x2100_scrot.png Screenshot Guillaume Subiron, 11/27/2015 07:09 PM

Associated revisions

Revision 02e0e73b (diff)
Added by Ulrich Pegelow about 4 years ago

elliptic mask shape: give choice of equidistant and proportional feathering

rationale: previously equidistant feathering has been the default. frequently a
proportional feathering would be more natural for an ellipse. in addition equidistant
feathering can provoke some ugly (albeit mathematically correct) mask appearance in
case of a big feathering area and a large eccentricity. toggling between the two modes
is done by Shift-Clicking on the shape.

this addresses redmine ticket #10743

History

#1 Updated by Ulrich Pegelow about 4 years ago

You are probably right that the fethering of the ellipse would have better been designed in the way you describe. However, there is no simple way to change the current behavior without sacrificing backwards compatibility - and that's something we strictly need to avoid.

That said the easiest solution for you to get the desired result is using the path shape instead of the ellipse. The path will allow you to generate an ellipse look-alike with full freedom on the fethering characteristics.

I will take your proposal into consideration for the future.

#2 Updated by Guillaume Subiron about 4 years ago

I completely understand. Thanks for your answer and thanks a lot for the workaround. I find the path shape quite hard to use, but I will try it.

Thank you.

#3 Updated by Ulrich Pegelow about 4 years ago

  • % Done changed from 0 to 50
  • Status changed from New to In Progress

I might have found a way to transparently change the ellipse feathering while keeping legacy behavior. As this might introduce bugs and needs intensive testing I will only implement it after the 2.0 release.

#4 Updated by Ulrich Pegelow about 4 years ago

  • Target version set to Future

#5 Updated by Guillaume Subiron about 4 years ago

This would be awesome. I will be very happy to test it.

#6 Updated by Ulrich Pegelow about 4 years ago

This is now implemented in master. I opted for giving a choice of both types of feathering (equidistant and proportional). You switch between the two modes by shift-clicking on the shape.

#7 Updated by Ulrich Pegelow about 4 years ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

#8 Updated by Roman Lebedev over 3 years ago

  • Target version changed from Future to 2.2.0

Also available in: Atom PDF

Go to top