Project

General

Profile

Bug #10705

Dragging histogram yields crazy results

Added by Anonymous over 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
11/08/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0rc1
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I think it should be possible to change exposure and black point by dragging the histogram. It does not work for me at all: Exposure instantly goes up to +9EV on the slightest drag in any direction, and when dragging left, the histogram looses focus before I'm even close to normal. Black point is slightly better since it does not jump to insane value immediately, but also looses focus to soon. Also, selecting a color channel or histogram mode (linear) has no effect at all.

I observe this on v1.6.9, and on `release-2.0rc1` and on `g39d3ef6`.

I am not the only one affected by this:
http://sourceforge.net/p/darktable/mailman/darktable-users/?viewmonth=201511&viewday=8&style=threaded

Associated revisions

Revision 106a8c10 (diff)
Added by Alexander V. Smal about 4 years ago

Fix for bug #10705 "Dragging histogram yields crazy results"

Revision a4d2702b (diff)
Added by Alexander V. Smal about 4 years ago

histogram: Corrected mouse scrolling/dragging on the histogram

Fixes #10073 and fixes #10705

Mouse scrolling and dragging on the right part of the histogram (exposure) was
implemented in terms of "white", not in terms of "exposure". That caused
incorrect behavior (#10705): the slightest drag in any direction changed
exposure by several EV, scrolling changed exposure in non-linear way. On the
other hand dragging and scrolling in the "auto" exposure mode was done
in terms of target exposure value, passing "white" and "exposure" via
the same hooks caused #10073.

(cherry picked from commit 106a8c107adf9eb57fd1f4ab9a93886d44977f67)
(cherry picked from commit 16111102d97933556f34901f7cf0ec2353ab5344)
(cherry picked from commit 4f5e5e42c923f5e3d1f104fa282faabf24d16208)

History

#1 Updated by Roman Lebedev over 4 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

What about mouse wheel?
Does it also cause such big exposure jumps?

#2 Updated by Anonymous over 4 years ago

Roman Lebedev wrote:

What about mouse wheel? Does it also cause such big exposure jumps?

Mouse wheel on black point works well, each click is 0.0010. But for exposure, the value changes more the higher the value is, and changes less with negative exposure compensation.

These are the steps for scrolling up:

0.0 0.15 0.32 0.51 0.74 1.00 1.32 1.74 2.32 3.32 9.97

I have verified this with `release-1.6.9` and `release-2.0rc1`.

I never use this (nor dragging) but it's documented to work.

#3 Updated by Alexander Smal about 4 years ago

  • % Done changed from 20 to 100
  • Status changed from Incomplete to Fixed

Fixed in the master branch

#5 Updated by Roman Lebedev over 3 years ago

  • Target version changed from Candidate for next major release to 2.2.0

Also available in: Atom PDF

Go to top