Project

General

Profile

Bug #10695

darktable unselective when trying to read input and output color profiles

Added by Ulrich Pegelow over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Category:
General
Start date:
11/03/2015
Due date:
% Done:

100%

Affected Version:
2.0rc1
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

At program startup when darktable tries to get all input and output profiles in {userconfig,datadir}/color/{in,out}/*.icc in function dt_colorspaces_init() all files in the respective folders are treated as possible profile files. We leave it to littleCMS2 to identify which files contain valid profiles.

This has two adverse effects:

  • an error messages is emitted to the console for each invalid file (including for example hidden files, generated some file managers and the like)
  • even if there are legacy profiles kept for backup these are imported (e.g. xyz.icc.bak)

What darktable should do: only read profiles with legitimate extensions (.icc, .icm, both in all combinations of lower and upper case letters)

Associated revisions

Revision a56a6866
Added by Tobias Ellinghaus over 3 years ago

Ignore color profiles not ending in .icc or .icm

Fixes #10695

Revision aabc0dbe
Added by Tobias Ellinghaus over 3 years ago

Fix #10695 for real (also accept upper case)

History

#1 Updated by Tobias Ellinghaus over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#2 Updated by Ulrich Pegelow over 3 years ago

  • Assignee set to Tobias Ellinghaus

Hi Tobias,

thanks for the quick fix. One thought: as we don't know where the profiles come from, we might need to take into account profile names with upper case extensions (or even mixed upper/lower case). Now only .icc and .icm (all lower case) are accepted.

Ulrich

#3 Updated by Tobias Ellinghaus over 3 years ago

Sorry, my bad, at first I used g_ascii_strcasecmp. I guess I will go back to that.

Also available in: Atom PDF