Project

General

Profile

Bug #10654

"Restrict histogram to selection" restricts to more than selection

Added by Matthieu Moy over 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
10/04/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
1.6.8
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,

The "restrict histogram to selection" tickbox does not work as expected for me. Instead of restricting to the rectangle selection, it seems to restrict to the whole vertical slice containing the selection. It's hard to check on a real photo, so I made a small test picture (test-colors.png). When I select a completely white area below the red rectangle and the green one (vertical-not-white.png), the selection is completely white, but I still see peaks on the low end of the histogram, which seem to correspond to the red and green rectangles. Actually, if I move my rectangle vertically, the histogram doesn't change (within-red.png), even though the selection is now completely red. OTOH, if I select an area where all the pixels above and below are white, I do get a histogram of a white picture.

This happens both with "linear" and "logarithmic" histograms. The "waveform" histogram seems unaffected by the selection.

Thanks,

vertical-not-white.png (52.8 KB) vertical-not-white.png A white selection, with non-white pixels on the same column Matthieu Moy, 10/04/2015 01:21 PM
vertical-white.png (52.2 KB) vertical-white.png A white selection, with only white pixels on the same column Matthieu Moy, 10/04/2015 01:21 PM
within-red.png (53.3 KB) within-red.png A selection within red Matthieu Moy, 10/04/2015 01:21 PM
test-colors.png (1.44 KB) test-colors.png The image I used for tests Matthieu Moy, 10/04/2015 01:21 PM

Associated revisions

Revision 57307ed2
Added by Roman Lebedev about 4 years ago

Merge pull request #1165 from moy/histogram

Colorpicker: fix "restrict histogram" bounding box. Fixes #10654

History

#1 Updated by Matthieu Moy over 4 years ago

Still present in Git master (e4b7eba82eacf2315986b75587b40c445c2752c8).

#2 Updated by Roman Lebedev about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#3 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top