Project

General

Profile

Bug #10640

clamp max cpu required for Solaris to SSE4.2

Added by James C. McPherson over 4 years ago. Updated over 4 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
09/21/2015
Due date:
% Done:

100%

Estimated time:
0.10 h
Affected Version:
1.6.7
System:
Solaris
bitness:
64-bit
hardware architecture:
amd64/x86

Description

To help guard against building Darktable with cpu instructions that aren't supported on older cpus (but which are still supported by Solaris), we need to avoid passing -march=native to gcc and g++.

This patch provides the requisite safety:

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
$ cat CMakeLists.txt.diff
--- vanilla-darktable-1.6.7/src/CMakeLists.txt Sun Jun 7 19:40:16 2015
+++ darktable-1.6.7-working/src/CMakeLists.txt Mon Sep 21 08:52:31 2015
@ -394,11 +394,13 @

if(NOT CUSTOM_CFLAGS)
#we MUST always specify our requred instruction set, native might not detect it
set(DT_REQ_INSTRUCTIONS "-msse3")

- if(NOT BINARY_PACKAGE_BUILD AND (NOT APPLE OR CMAKE_C_COMPILER_ID STREQUAL "Clang"))
+ if (CMAKE_SYSTEM_NAME STREQUAL "SunOS")
+ set(MARCH "-msse4.2")
+ elseif(NOT BINARY_PACKAGE_BUILD AND (NOT APPLE OR CMAKE_C_COMPILER_ID STREQUAL "Clang"))
MESSAGE
CHECK_C_COMPILER_FLAG("-march=native" MARCHNATIVE)
if (MARCHNATIVE)
set(MARCH "-march=native")
else()

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Associated revisions

Revision 9dfebd0e (diff)
Added by James C. McPherson over 4 years ago

clamp max cpu required for Solaris to SSE4.2

Fixes #10640

Revision 291e38d9 (diff)
Added by James C. McPherson over 4 years ago

clamp max cpu required for Solaris to SSE4.2

Fixes #10640

(cherry picked from commit 9dfebd0e14a3ea323de100e34b5461c2bb979b13)

History

#1 Updated by James C. McPherson over 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

Also available in: Atom PDF

Go to top