Project

General

Profile

Bug #10636

multi-instances: If multi instancing of a module is used on an image, the module is named wrong in the next image

Added by Björn Sonnenschein over 3 years ago. Updated almost 2 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
09/17/2015
Due date:
% Done:

100%

Affected Version:
git development version
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

If a new instance of a module is created and moved to the bottom, if another image is opened from the filmstrip, the module in the new image will be named like the second instance.

How to reproduce:
1. Import a folder with at least two images and open the first image in the darkroom.
2. create a new instance of a module, for example of the exposure module. The new instance's name should be Exposure 1 and it is positioned above the first instance.
3. use "move down" to place exposure 1 under exposure.
4. in the filmstrip panel, open another image via double click. the exposure module is named exposure 1 in the new image's module stack, too, which is wrong.

0001-dt_dev_change_image-reset-mi-name-too.-Fixes-10636.patch Magnifier - Patch: dt_dev_change_image(): reset mi name too. (813 Bytes) Žilvinas Žaltiena, 07/04/2017 08:35 PM

Associated revisions

Revision b27e5c3b
Added by Žilvinas Žaltiena almost 2 years ago

dt_dev_change_image(): reset mi name too. Fixes #10636

Revision 42b550bc
Added by Roman Lebedev almost 2 years ago

Merge remote-tracking branch 'upstream/pr/1511'

  • upstream/pr/1511:
    dt_dev_change_image(): reset mi name too. Fixes #10636

History

#1 Updated by Žilvinas Žaltiena almost 2 years ago

When image is changed in darkroom's strip, all module's instances except the "base" one are removed, remaining "base" instance gets its priority reset, and defaults loaded, however instance name (multi_name) is left as is from previous image. The attached patch fixes that.

#2 Updated by Žilvinas Žaltiena almost 2 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#3 Updated by Roman Lebedev almost 2 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF