Project

General

Profile

Bug #10306

lighttable shows black thumbs on photos without a history stack

Added by Markus Kanet over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Lighttable
Target version:
Start date:
02/02/2015
Due date:
% Done:

100%

Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I have installed latest git/master using build.sh inside of a virtual machine, so i have a clean install and no previous config files.

What happens after i have started darktable and selected a directory to import is that all photos will show up on lighttable with black thumbs. Only photos that have to be rotated will show up correct. See screenshot #1.

If i open a photo in darkroom the photo will show up correct. See screenshot #2. When i switch back to lighttable this photos does now also show up correct.

If i close darktable and restart the application all photos in lighttable are now corrupt. See screenshot #3. The photos do still work if i open a photo in darkroom. It's really only the thumbnail in lightroom which shows up in black.

For testing i disabled the mimmap disk cache and deleted all thumbnails from the disk cache. After restarting darktable the edited photos are back with correct thumbs, all others stay in black. See screenshot #4. Restarting darktable with disk cache disabled will bring up the same thumbs again. Only untouched photos will remain with a black thumbnail.

I enabled the disk cache again and closed darktable. The cached files look ok, except for the untouched photos which will have just a black preview jpg. See Screenshot #5.

If i open darktable again and close it without any changes even the thumbnails will look bad. See screenshot #6.

This problem first appeared some when after last x-mas. I have edited these photos before i was on vacation, so the photos were are all OK. The complete folder has something like 3500 photos, it happens to all of them. Does not make any difference if i remove all the xmp files. As soon as the photos are unchanged they will show a black preview.

If i delete the config/library and the disk cache and copy the xmp files from the original photo folder i get at least a preview for all edited photos. See screenshot #7: All photos with a history stack have a working thumbnail. If i close the application now all of the thumbs in the mipmap cache show garbage.

The photos were taken in 2011 with a Canon EOS 7D.

darktable-01.png - Screenshot #1 (110 KB) Markus Kanet, 02/02/2015 07:05 AM

darktable-04.png - Screenshot #2 (456 KB) Markus Kanet, 02/02/2015 07:08 AM

darktable-05.png - Screenshot #3 (124 KB) Markus Kanet, 02/02/2015 07:10 AM

darktable-06.png - Screenshot #4 (155 KB) Markus Kanet, 02/02/2015 07:13 AM

darktable-07.png - Screenshot #5 (369 KB) Markus Kanet, 02/02/2015 07:16 AM

darktable-08.png - Screenshot #6 (374 KB) Markus Kanet, 02/02/2015 07:17 AM

darktable-09.png - Screenshot #7 (181 KB) Markus Kanet, 02/02/2015 07:26 AM

darktable-10.png - Stable 1.6 Branch (307 KB) Markus Kanet, 02/02/2015 07:53 AM

darktable-d-all.txt Magnifier - Debug messages (446 KB) Markus Kanet, 02/03/2015 07:05 AM

Associated revisions

Revision fe223be1
Added by Roman Lebedev over 3 years ago

Fix libjpeg (non-turbo) decompress usage. Fixes #10306

History

#1 Updated by Markus Kanet over 3 years ago

For testing i installed the 1.6 stable branch from git, deleted cache and config, started darktable, imported the same folder as shown above and i get all thumbs. Even after a restart everything works fine. See screenshot.

#2 Updated by Roman Lebedev over 3 years ago

Is there any output on console?

#3 Updated by Roman Lebedev over 3 years ago

Also, against which versions of libjpeg (libjpeg-turbo ?) and graphicsmagick DT were built?

#4 Updated by Roman Lebedev over 3 years ago

And which exiv2 version?

#5 Updated by Markus Kanet over 3 years ago

graphicsmagick: 1.3.20
libjpeg v8a
exiv2 0.24

Here is the config log from running build.sh

Darktable build script

Building directory: ./build
Installation prefix: /opt/darktable/
Build type: Release
Make program: make
Make tasks: 5

-- The CXX compiler identification is GNU 4.8.2
-- The C compiler identification is GNU 4.8.2
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for external programs
-- Found perl
-- Found intltool-merge
-- Found xsltproc
-- Found xmllint
-- All external programs found
-- Found Gettext
-- Found msgfmt to convert language file. Translation enabled
-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: fopenmp
-
Found PkgConfig: /usr/bin/pkg-config (found version "0.25")
-- checking for module 'gtk+-3.0'
-- found gtk+-3.0, version 3.14.7
-- checking for module 'gdk-pixbuf-2.0'
-- found gdk-pixbuf-2.0, version 2.30.8
-- checking for module 'glib-2.0'
-- found glib-2.0, version 2.42.1
-- Found Glib
-- checking for module 'pango'
-- found pango, version 1.36.8
-- checking for module 'atk'
-- found atk, version 2.14.0
-- Found GTK3: /usr/lib64/libgtk-3.so (Required is at least version "3.10")
-- Found LibXml2: /usr/lib64/libxml2.so (found suitable version "2.9.1", minimum required is "2.6")
-- Found GPHOTO2: /usr/lib64/libgphoto2.so
-- Found OPENEXR: /usr/lib64/libIlmImf.so;/usr/lib64/libImath.so;/usr/lib64/libIex.so;/usr/lib64/libIlmThread.so
-- checking for module 'libwebp'
-- found libwebp, version 0.4.2
-- Found WEBP: /usr/lib64/libwebp.so (Required is at least version "0.3.0")
-- checking for module 'lensfun'
-- found lensfun, version 0.3.0.0
-- Found LENSFUN: /usr/lib64/liblensfun.so
-- checking for module 'gio-2.0'
-- found gio-2.0, version 2.42.1
-- Found GIO
-- Found GThread: /usr/lib64/libgthread-2.0.so
-- Found GModule: /usr/lib64/libgmodule-2.0.so
-- Found PANGOCAIRO: /usr/lib64/libpangocairo-1.0.so
-- Found PThread: /usr/lib64/libpthread.so
-- Found RSVG2: /usr/lib64/librsvg-2.so
-- Found LibXml2: /usr/lib64/libxml2.so (found version "2.9.1")
-- Found SQLITE3: /usr/lib64/libsqlite3.so
-- Found EXIV2: /usr/lib64/libexiv2.so
-- Found CURL: /usr/lib64/libcurl.so (found version "7.36.0")
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.8")
-- Found PNG: /usr/lib64/libpng.so (found version "1.4.12")
-- Found JPEG: /usr/lib64/libjpeg.so
-- Found TIFF: /usr/lib64/libtiff.so (found version "3.9.7")
-- Found LCMS2: /usr/lib64/liblcms2.so
-- Internationalization: Enabled
-- Found FLICKCURL: /usr/lib64/libflickcurl.so
-- checking for module 'json-glib-1.0'
-- package 'json-glib-1.0' not found
-- checking for module 'libopenjpeg1'
-- found libopenjpeg1, version 1.5.1
-- Found OpenJPEG: /usr/lib64/libopenjpeg.so
-- checking for module 'gnome-keyring-1'
-- found gnome-keyring-1, version 3.12.0
-- Found GNOMEKEYRING: /usr/lib64/libgnome-keyring.so
-- GnomeKeyring is only supported for versions older than 3.12.0, version 3.12.0 found. Please use libsecret instead.
-- checking for module 'GraphicsMagick'
-- found GraphicsMagick, version 1.3.20
-- Found GraphicsMagick
-- Performing Test MARCHNATIVE
-- Performing Test MARCHNATIVE - Success
-- checking for one of the modules 'lua5.2;lua-5.2;lua'
-- Lua support: System library not found (to use darktable's version use DDONT_USE_INTERNAL_LUA=Off)
-
checking for module 'osmgpsmap-1.0'
-- found osmgpsmap-1.0, version 1.0.2
-- Map mode: enabled
-- checking for module 'colord'
-- package 'colord' not found
-- No libcolord found, this build will lack the ability to get the screen profile from colord
-- Found CUPS: /usr/lib64/libcups.so
-- Print mode: enabled
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib64/libX11.so
-- no colord support for darktable-cmstest. not cool.
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- Found SDL: /usr/lib64/libSDLmain.a;/usr/lib64/libSDL.so (found version "1.2.15")
-- Found OpenGL: /usr/lib64/libGL.so
--
-- Could NOT find Java (missing: Java_JAR_EXECUTABLE Java_JAVAC_EXECUTABLE Java_JAVAH_EXECUTABLE Java_JAVADOC_EXECUTABLE) (found version "1.8.0.31")
-- No saxon XSLT processor and/or no docbook saxon extension library found.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/markus/darktable.2/darktable/build

#6 Updated by Markus Kanet over 3 years ago

No special messages on the console... i did a darktable -d all and do not see anything special.

I installed latest git/master, deleted all cache/config files, started darktable, imported the folder with the images in the screenshots above. Attached is the debug/all output from the console.

#7 Updated by Roman Lebedev over 3 years ago

  • Assignee set to Roman Lebedev

Ok, so i have, as expected, broke something with PR818

#8 Updated by Roman Lebedev over 3 years ago

  • System changed from other GNU/Linux to all
  • Status changed from New to Confirmed
  • % Done changed from 0 to 10

#9 Updated by Markus Kanet over 3 years ago

Looks like... i downloaded git previous to your commit 61ba715 "dt_imageio_jpeg_decompress(): use libjpeg-turbo JCS_EXT_RGBX, if available". Before this commit darktable shows all thumbs. If i use git after this commit thumbs with no history stack are black like on screenshot#1 and after a restart all thumbs show garbage like on screenshot#3.

#10 Updated by Roman Lebedev over 3 years ago

  • Status changed from Confirmed to Fixed
  • % Done changed from 10 to 100

#11 Updated by Markus Kanet over 3 years ago

Latest git/master works for me, thanks.

Also available in: Atom PDF