Project

General

Profile

Bug #10289

Lens Recognition

Added by Martin Jones about 5 years ago. Updated about 5 years ago.

Status:
Closed: invalid
Priority:
Low
Assignee:
-
Category:
General
Start date:
01/17/2015
Due date:
% Done:

0%

Estimated time:
Affected Version:
1.6.1
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

My Tamron SP AF 10-24mm f/3.5-4.5 Di II LD Aspherical (IF) is not automatically recognized by darktable. On the left pane window for image Info under Lens ID it simply states "246". I have to manually select the lens from the database (is listed). Lens correction data works.

DSC_3255.NEF (29.4 MB) DSC_3255.NEF Martin Jones, 01/17/2015 06:45 PM

History

#1 Updated by Pascal de Bruijn about 5 years ago

This is NOT a Darktable issue. Lens recognition is handled by the Exiv2 library.

If you supply us with a sample RAW file, I might be able to provide some guidance on how to approach this issue.

#2 Updated by Martin Jones about 5 years ago

thanks for your quick feedback Pascal. Here a link can download a NEF.

thanks in advance for your help.

#3 Updated by Martin Jones about 5 years ago

Martin Jones wrote:

thanks for your quick feedback Pascal. Here a you can download the attached NEF.

thanks in advance for your help.

#4 Updated by Pascal de Bruijn about 5 years ago

Right, so... The EXIF MakerNote has field identifying the lens, which Exiv2 translates to name using a big lookup table:

$ exiv2 -pt DSC_3255.NEF | strings | grep -i lens
Exif.Nikon3.LensType Byte 1 D G
Exif.Nikon3.Lens Rational 4 10-24mm F3.5-4.5
Exif.Nikon3.LensFStops Undefined 4 5.25
Exif.NikonLd3.LensIDNumber Byte 1 246
Exif.NikonLd3.LensFStops Byte 1 F5.2

Nikon is a bit of a special case, as the translation list is maintained outside of the Exiv2 project, and uses some other fields as well, so exiftool's output is a bit more useful:

$ exiftool DSC_3255.NEF | grep -i lens
Lens Type : G
Lens : 10-24mm f/3.5-4.5
Lens Data Version : 0204
Lens ID Number : 246
Lens F Stops : 5.25
Lens ID : Unknown (F6 3F 18 37 2C 34 DF 06)
Lens : 10-24mm f/3.5-4.5 G

A similar model is already known but with a slightly different ID:
exiv2 trunk/src/nikonmn.cpp: {0xF6,0x3F,0x18,0x37,0x2C,0x34,0x84,0x06,0x01,0x00,0x00, "Tamron", "B001", "SP AF 10-24mm F/3.5-4.5 Di II LD Aspherical (IF)"},

Presumably you don't have the B001 model? Could you check exactly which model you have?

#5 Updated by Pascal de Bruijn about 5 years ago

A fairly simple patch to Exiv2 seems to remediate the issue, however I'm not quite sure of it's correctness:

diff Nurpd a/src/nikonmn.cpp b/src/nikonmn.cpp
--
a/src/nikonmn.cpp 2015-01-18 14:06:45.037908497 0100
+
+ b/src/nikonmn.cpp 2015-01-18 14:41:17.856827504 +0100
@ -2185,6 +2185,7 @ fmountlens[] = { {0x27,0x54,0x8E,0x8E,0x24,0x24,0x1D,0x02,0x00,0x00,0x00, "Tamron", "360E", "SP AF 300mm F/2.8 LD-IF"},
// {0xF6,0x3F,0x18,0x37,0x2C,0x34,0x84,0x06,0x01,0x00,0x00, "Tamron", "B001", "SP AF 10-24mm F/3.5-4.5 Di II LD Aspherical (IF)"},
+{0xF6,0x3F,0x18,0x37,0x2C,0x34,0xDF,0x06,0x00,0x00,0x00, "Tamron", "B001", "SP AF 10-24mm F/3.5-4.5 Di II LD Aspherical (IF)"}, {0x00,0x36,0x1C,0x2D,0x34,0x3C,0x00,0x06,0x00,0x00,0x00, "Tamron", "A13", "SP AF 11-18mm F/4.5-5.6 Di II LD Aspherical (IF)"}, {0xEA,0x40,0x29,0x8E,0x2C,0x40,0xDF,0x0E,0x00,0x00,0x00, "Tamron", "B016", "AF 16-300mm F/3.5-6.3 Di II VC PZD"}, {0x07,0x46,0x2B,0x44,0x24,0x30,0x03,0x02,0x00,0x00,0x00, "Tamron", "A05", "SP AF 17-35mm F/2.8-4 Di LD Aspherical (IF)"},

As I mentioned the fmount list is maintained separately from the Exiv2 project, so I would suggest for you to contact it's maintainer (and refer to this dt issue):

// Created by Robert Rottmerhusen 2005 - 2014
// http://www.rottmerhusen.com (lens_id@rottmerhusen.com)
//
// For contributor info and more visit my online list:
// http://www.rottmerhusen.com/objektives/lensid/thirdparty.html

Keep in mind that the Exiv2 project is working toward a new release, so I'd highly recommend to expedite contact, so you have a chance this might be added before Exiv2 0.25 is released.

I'd appreciate it, if you'd keep me posted.

#6 Updated by Martin Jones about 5 years ago

Hi Pascal,

yes, indeed it is the B001 model I have!
Ill make contact with the developer as requested.

Regards
Martin

#7 Updated by Martin Jones about 5 years ago

Hi Pascal,

here the feedback from Robert:

the updates are online.

You can download the haeder files form my homepage. This is the place
exiv2 also gets the data.

Normal List:
rottmerhusen.com/objektives/lensid/files/c-header/fmountlens4.h

List with work-around for lensfun (Tamron lenses):
rottmerhusen.com/objektives/lensid/files/c-header/fmountlens4t.h

now I dont know how to proceed.

#8 Updated by Pascal de Bruijn about 5 years ago

Right.

So now the source where Exiv2 gets it's list from is updated, you can file an issue with the Exiv2 project, that your lens isn't being recognized, and that Robert has updated his list to include your lens, and ask if they can resync with the list from Robert:

http://dev.exiv2.org/projects/exiv2/issues

#9 Updated by Martin Jones about 5 years ago

Done. here the feedback from the Exiv2 team.

Thank you for the report. I have update the Nikon lens list in the svn trunk (r3576).

Best regards,
Niels Kristian Bech Jensen

How should I now proceed?

#10 Updated by Pascal de Bruijn about 5 years ago

  • Status changed from New to Closed: invalid

Great.

So if I'm not mistaken that change (see below) will likely make it into Exiv2 0.25, which will ship in future distributions.

http://dev.exiv2.org/projects/exiv2/repository/revisions/3576/diff/trunk/src/nikonmn.cpp

First it has to make it into Debian and then trickle down to Ubuntu. So realisticly Ubuntu 15.10 will likely be the first version to have this change out of the box.

Now, for 14.04 LTS exclusively, I maintain the old Exiv2 0.23 out of band with patches from time to time, and I've just pushed a new patched Exiv2 package to my darktable-unstable PPA for testing. This will likely trickle down to my darktable-release PPA in a week (or two).

I'll be closing this issue as "Closed: invalid", since this was never a darktable issue to begin with, and we were just using this issue as a means of communication.

Also available in: Atom PDF

Go to top