Project

General

Profile

Bug #10241

0.35° defaullt angle when moving graduated filter

Added by Julien CHIQUET over 4 years ago. Updated over 4 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Target version:
-
Start date:
12/20/2014
Due date:
% Done:

100%

Affected Version:
1.6.0
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Trying to move the graduated filter in a picture using the mouse :
- when rotation angle is set to whatever value except zero before moving, then it keeps it's value.
- when rotation angle is set to zero before moving, then it is always reset to default 0.35°. It should keep its value.

Tests is done with darktable 1.6 and ubuntu 14.04LTS 64-bit.

Associated revisions

Revision 92914ef1
Added by Roman Lebedev over 4 years ago

Graduatednd IOP: avoid rounding issues for rotation after moving whole line. Fixes #10241

Revision c1a806df
Added by Roman Lebedev over 4 years ago

Graduatednd IOP: avoid rounding issues for rotation after moving whole line. Fixes #10241

(cherry picked from commit 92914ef17be6ba3875b7f0260cf02fd2754cdc91)

Revision 9d5b2214
Added by Roman Lebedev over 4 years ago

Merge remote-tracking branch 'upstream/master' into gtk3

  1. By Pascal Obry (9) and others
  2. Via Ger (1) and others
    • upstream/master: (39 commits)
      wb_presets: fix 7D Mark II (#10243)
      Fix reference of wb_presets.c in POFILES.in.
      Add the Pentax *ist DL2 do rawspeed
      snapshots: fix drawing offset for new border system. fixes #10228
      add "// clang-format {off,on}" to nvidia_gpus.h
      Update beautify_style.sh
      Move wb_presets.c to external/
      dt_imageio_export_with_flags(): do not leak memory upon error. Fixes Coverity CID 1260259
      Some more const where possible.
      Diferent black points for samsung NX1 high iso
      Minor code rewrite to avoid distributed complexity.
      Use const qualifier where possible.
      [usermanual] Make sure URLs to external HTML files aren't getting .php appended
      Add some const qualifier where possible.
      Updated Dutch translation
      Update French translation.
      Improve tooltip text for style append.
      Graduatednd IOP: avoid rounding issues for rotation after moving whole line. Fixes #10241
      basecurve: cleanup table layout butched by clang-format
      exif: always try to use Exiv2's lens detection for Olympus
      ...

Conflicts:
src/imageio/format/exr.cc
src/imageio/format/j2k.c
src/imageio/format/jpeg.c
src/imageio/format/png.c
src/imageio/format/tiff.c
src/imageio/format/webp.c
src/libs/export.c

History

#1 Updated by Pascal de Bruijn over 4 years ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed

#2 Updated by Roman Lebedev over 4 years ago

  • Assignee set to Roman Lebedev

#3 Updated by Roman Lebedev over 4 years ago

Julien CHIQUET wrote:

- when rotation angle is set to whatever value except zero before moving, then it keeps it's value.

Wrong. Almost all rotation angles do change, although by a very small amount.

#5 Updated by Roman Lebedev over 4 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

Also available in: Atom PDF