Project

General

Profile

Bug #10228

Snapshots are working not correctly

Added by Sergio Dolgopoloff almost 5 years ago. Updated almost 5 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
-
Start date:
12/14/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Snapshots are working not correctly. Video and screenshot attached.

Darktable 1.6.0+16~g8dee292
kubuntu 14.04

dtscreen.png (2.53 MB) dtscreen.png Sergio Dolgopoloff, 12/14/2014 01:31 AM
dts (2.15 MB) dts Sergio Dolgopoloff, 12/14/2014 01:31 AM

Associated revisions

Revision e37dcdbe (diff)
Added by Johannes Hanika almost 5 years ago

snapshots: fix drawing offset for new border system. fixes #10228

Revision ab30ec4a (diff)
Added by Johannes Hanika almost 5 years ago

snapshots: fix drawing offset for new border system. fixes #10228

Revision 995f4c1b (diff)
Added by Johannes Hanika almost 5 years ago

snapshots: fix drawing offset for new border system. fixes #10228

(cherry picked from commit ab30ec4abd8c1bdf5e0b5e82479f86d1036b3622)

Revision 9d5b2214
Added by Roman Lebedev almost 5 years ago

Merge remote-tracking branch 'upstream/master' into gtk3

  1. By Pascal Obry (9) and others
  2. Via Ger (1) and others
    • upstream/master: (39 commits)
      wb_presets: fix 7D Mark II (#10243)
      Fix reference of wb_presets.c in POFILES.in.
      Add the Pentax *ist DL2 do rawspeed
      snapshots: fix drawing offset for new border system. fixes #10228
      add "// clang-format {off,on}" to nvidia_gpus.h
      Update beautify_style.sh
      Move wb_presets.c to external/
      dt_imageio_export_with_flags(): do not leak memory upon error. Fixes Coverity CID 1260259
      Some more const where possible.
      Diferent black points for samsung NX1 high iso
      Minor code rewrite to avoid distributed complexity.
      Use const qualifier where possible.
      [usermanual] Make sure URLs to external HTML files aren't getting .php appended
      Add some const qualifier where possible.
      Updated Dutch translation
      Update French translation.
      Improve tooltip text for style append.
      Graduatednd IOP: avoid rounding issues for rotation after moving whole line. Fixes #10241
      basecurve: cleanup table layout butched by clang-format
      exif: always try to use Exiv2's lens detection for Olympus
      ...

Conflicts:
src/imageio/format/exr.cc
src/imageio/format/j2k.c
src/imageio/format/jpeg.c
src/imageio/format/png.c
src/imageio/format/tiff.c
src/imageio/format/webp.c
src/libs/export.c

History

#1 Updated by Roman Lebedev almost 5 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

Works fine here in git master, can not confirm.

#2 Updated by Sergio Dolgopoloff almost 5 years ago

Roman Lebedev wrote:

Works fine here in git master, can not confirm.

Bug is on, when maximum width of image drawing area <1300 pixels (in darktable preferences). In my case width of image 1150px.

#3 Updated by Roman Lebedev almost 5 years ago

  • System changed from Ubuntu to all
  • % Done changed from 20 to 10
  • Status changed from Incomplete to Confirmed

#4 Updated by Pascal de Bruijn almost 5 years ago

This might be a regression due to: https://github.com/darktable-org/darktable/commit/e72625e06da05e4abd7ce9e606498239e7a58ef8

I've removed it from the 1.6.x maintenance tree.

#5 Updated by Johannes Hanika almost 5 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

Also available in: Atom PDF

Go to top