Project

General

Profile

Bug #10190

darktable crushes at launch

Added by Sergio Dolgopoloff about 5 years ago. Updated about 5 years ago.

Status:
Fixed
Priority:
Medium
Category:
General
Start date:
11/07/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

pardon my english...
darktable 1.5+2221~g0ddbd29-0pmjdebbruijn1~trusty crashes immediately after launch
Kubuntu 14.04
dump attached

darktable_bt_WBB0OX.txt (19.3 KB) darktable_bt_WBB0OX.txt Sergio Dolgopoloff, 11/07/2014 09:26 PM

Related issues

Has duplicate darktable - Bug #10191: Crash with start DTDuplicate11/09/2014

Associated revisions

Revision 4f19ccac (diff)
Added by Tobias Ellinghaus about 5 years ago

Don't depend on a max size for variables tooltip

Fixes #10190

History

#1 Updated by Ulrich Pegelow about 5 years ago

  • Priority changed from Low to Medium

That's probably a Unicode/UTF-8 related bug in your local language (Russian?). It seems to be triggered by the tooltip that gets defined in src/imageio/storage/disk.c:159.

g_markup_escape_text() which is called within the gtk routines is not robust against invalid characters and will crash.

Please tell us what local language you use so we can bump the translator.

#2 Updated by Sergio Dolgopoloff about 5 years ago

Ulrich Pegelow wrote:

That's probably a Unicode/UTF-8 related bug in your local language (Russian?). It seems to be triggered by the tooltip that gets defined in src/imageio/storage/disk.c:159.

g_markup_escape_text() which is called within the gtk routines is not robust against invalid characters and will crash.

Please tell us what local language you use so we can bump the translator.

Yes, my local language is Russian

#3 Updated by Ulrich Pegelow about 5 years ago

@Alexandre: could you have a look?

The code in question seems to be this:

  dt_gtkentry_setup_completion(GTK_ENTRY(widget), dt_gtkentry_get_default_path_compl_list());

  char *tooltip_text = dt_gtkentry_build_completion_tooltip_text (
                         _("enter the path where to put exported images\nrecognized variables:"),
                         dt_gtkentry_get_default_path_compl_list());

Either we might have an invalid character in the translation of the string literal, or we get it through the specific completion technique.

If it's not the string literal we might need a solution like in commit ffc97f69e25779ce0fdfe4e99561dc99435486ef.

#4 Updated by Tobias Ellinghaus about 5 years ago

  • System changed from Ubuntu to all
  • Target version set to Candidate for next minor release
  • Assignee set to Tobias Ellinghaus

The bug is in dt_gtkentry_build_completion_tooltip_text which is allocating a fixed buffer size (which is too small for Russian). Who came up with code like that? o0

I will take care of it. Thanks for reporting.

#5 Updated by Tobias Ellinghaus about 5 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#6 Updated by Roman Lebedev about 5 years ago

  • Has duplicate Bug #10191: Crash with start DT added

Also available in: Atom PDF

Go to top