Project

General

Profile

Bug #10074

Lenses from Panasonic .RW2 files not recognized by dt

Added by Joerg Hoeben almost 5 years ago. Updated almost 5 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
General
Start date:
08/24/2014
Due date:
% Done:

100%

Affected Version:
1.4.2
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

RW2 files contains lens information and are readable by exiv2 (Version 0.23). Exiv2 output e.g.:
o Exif.Panasonic.ConversionLens Short 1 Off
Exif.Panasonic.LensType Ascii 34 LUMIX G VARIO PZ 14-42/F3.5-5.6
Exif.Panasonic.LensSerialNumber Ascii 14 01JI9152795H
o Exif.Panasonic.ConversionLens Short 1 Off
Exif.Panasonic.LensType Ascii 34 LUMIX G VARIO PZ 45-175/F4.0-5.6
Exif.Panasonic.LensSerialNumber Ascii 14 01II8061321H

dt doesn't seem to use "Exif.Panasonic.LensType" data. Panasonic lenses in "image information" module are "(unkown)" in lighttable and in "lens correction" module in darkroom.

RW2_examples.zip (35.1 MB) Joerg Hoeben, 08/24/2014 09:29 PM

History

#1 Updated by Pascal de Bruijn almost 5 years ago

  • Priority changed from High to Low

So you're stumbling into an issue where Adobe's DNG Converter would corrupt converted RW2 files' EXIF:

http://dev.exiv2.org/issues/779

Back then apparently a quick but ugly workaround was implemented which actually compromised RW2 support on behalf of the broken DNGs courtesy of Adobe:

https://github.com/darktable-org/darktable/blob/master/src/common/exif.cc#L774

#2 Updated by Joerg Hoeben almost 5 years ago

The RW2_examples provided are directly from a GH2 camera and exiv2 provides the correct lens information! It is a bad idea to disable a working feature because Adobes DNG Converter may have touched the RW2 file and corrupted the EXIF information. Exiv2 issue #779 is more than 3 years old and may be solved in the meantime? I do not use Adobes DNG Converter and not able to verify this.
Other suggestion for dt - is there a way to avoid dt to crash. The would allow to remove the ugly workaround.

#3 Updated by Pascal de Bruijn almost 5 years ago

  • % Done changed from 0 to 100
  • Target version set to Candidate for next major release
  • Status changed from New to Fixed

The original problematic sample is no longer available however.

For reference this is the original commit that introduced the "issue" and solved the other "issue":
https://github.com/darktable-org/darktable/commit/a4d85007ce98925f60aadf931ed36977d274718e.patch

The original problematic DNG is no longer available for download, but a random GH2 DNG I had lying around works just fine there days.

So I limited the somewhat draconic workaround to ancient versions of Exiv2 for the time being:

https://github.com/darktable-org/darktable/commit/c6ec500e4016d987337d44b8ba40c1e6ec1f3271

We'll probably remove it altogether at some point in the future.

Also available in: Atom PDF