Project

General

Profile

Bug #10073

Mouse wheel on histogram when using auto-exposure

Added by Emmanuel Lacour over 5 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
08/22/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Discovered on a few days ago git master, i f I select the exposure preset of magic-lantern, then if I use the mouse wheel on the top histogram to make the image darker, it becomes lighter. The opposit as manual exposure ;)

Associated revisions

Revision 16111102 (diff)
Added by Alexander Smal about 4 years ago

histogram: Corrected mouse scrolling/dragging on the histogram (fixes #10073 and #10705)

Mouse scrolling and dragging on the right part of the histogram (exposure) was
implemented in terms of "white", not in terms of "exposure". That caused
incorrect behavior (#10705): the slightest drag in any direction changed
exposure by several EV, scrolling changed exposure in non-linear way. On the
other hand dragging and scrolling in the "auto" exposure mode was done
in terms of target exposure value, passing "white" and "exposure" via
the same hooks caused #10073.

Revision a4d2702b (diff)
Added by Alexander V. Smal almost 4 years ago

histogram: Corrected mouse scrolling/dragging on the histogram

Fixes #10073 and fixes #10705

Mouse scrolling and dragging on the right part of the histogram (exposure) was
implemented in terms of "white", not in terms of "exposure". That caused
incorrect behavior (#10705): the slightest drag in any direction changed
exposure by several EV, scrolling changed exposure in non-linear way. On the
other hand dragging and scrolling in the "auto" exposure mode was done
in terms of target exposure value, passing "white" and "exposure" via
the same hooks caused #10073.

(cherry picked from commit 106a8c107adf9eb57fd1f4ab9a93886d44977f67)
(cherry picked from commit 16111102d97933556f34901f7cf0ec2353ab5344)
(cherry picked from commit 4f5e5e42c923f5e3d1f104fa282faabf24d16208)

History

#1 Updated by Roman Lebedev over 5 years ago

  • % Done changed from 0 to 10
  • Assignee set to Roman Lebedev
  • Status changed from New to Confirmed

I know, thanks for creating new issue.
When i implemented that, too many changes were needed to do it as it should be (not reverse)

#2 Updated by Tobias Ellinghaus over 5 years ago

  • System changed from Debian to all
  • % Done changed from 10 to 20
  • Status changed from Confirmed to Triaged
  • Category set to Darkroom

#3 Updated by Alexander Smal about 4 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

#4 Updated by Roman Lebedev about 4 years ago

  • Assignee deleted (Roman Lebedev)

#5 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top