Project

General

Profile

Bug #10064

highlight reconstruction in LCh: preview and histogram show result from clip highlights

Added by Robert Hutton over 5 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Target version:
Start date:
08/17/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

When using the highlight reconstruction module with the reconstruct in LCh method, the image preview and histogram display the results from the clip highlights method instead. This is particularly visible at extreme values. See attached screenshots.

Affected versions: 1.4.2 as well as the current git master.


Related issues

Related to darktable - Feature #9924: Mark clipped channels in the histogramTriaged04/27/2014

Related to darktable - Bug #10334: Color picker vs highlights recoveryFixed02/19/2015

History

#1 Updated by Roman Lebedev almost 5 years ago

  • System changed from Ubuntu to all
  • % Done changed from 0 to 10
  • Status changed from New to Confirmed

The reason for that, is that main preview is passing through "full" pipe without prior downsampling, as a raw uint16_t buffer, which is then subjected to `highlight reconstruction' iop,
while color picker samples the thumbnail you see in the top left corner of DR,
which passes through "preview" pipe, and it is pre-downsampled to 4xfloat buffer, and out of our highlight reconstruction algos, only "clip highlights" is implemented for such input.
So therefore, in such an corner case (not really) you see such an discrepancy in the color...

#2 Updated by Roman Lebedev almost 5 years ago

  • Related to Feature #9924: Mark clipped channels in the histogram added

#3 Updated by Roman Lebedev almost 5 years ago

  • Related to Bug #10334: Color picker vs highlights recovery added

#4 Updated by Roman Lebedev over 3 years ago

  • % Done changed from 10 to 100
  • Assignee set to Roman Lebedev
  • Status changed from Confirmed to Fixed

#5 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top