Project

General

Profile

Feature #10040

Darktable not reading the icc profile included in a TIFF file on import

Added by Gert van der Plas almost 5 years ago. Updated over 4 years ago.

Status:
Fixed
Priority:
Medium
Assignee:
-
Category:
Darkroom
Target version:
-
Start date:
08/07/2014
Due date:
% Done:

100%

Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Darktable does not seem to properly parse an the icc profile included a 16-bit TIFF file on import. The default input profile switches to sRGB (jpg) and uses that. If I use extracticc to extract the icc profile from the tiff, place the extracted icc profile in .config/darktable/colorin and select it in the colorin module, I get the proper colors. The issue seems to exist at least for both 16-bit tiffs generated by the Epson 4490 scanner software and the Sony Image Data Converter. The same tiffs read by other color aware linux software are parsed and displayed correctly, i.e. by the viewer Geeqie and RawTherapee. I suggest that the colorin profile should have an option to select the icc-profile from the input file and that using the included icc-profile should be selected by default, unless configured differently by a preset.

icc tiff stuff.zip (2.64 MB) Gert van der Plas, 08/08/2014 09:21 AM

epson_gamma_1.8.icc (444 Bytes) Long Wei, 09/13/2014 08:23 PM

nb0390_034_640.tif (260 KB) Long Wei, 09/13/2014 08:23 PM

screenshot.png - warning unsupported input profile (482 KB) Long Wei, 09/14/2014 04:26 AM


Related issues

Related to darktable - Bug #10110: Darkroom mode hangs after adjusting tone curve when unsupported embedded ICC profile is used Fixed 09/15/2014
Copied to darktable - Feature #10112: Supporting *Gray colorspace ICC profiles (16 bit) New 09/18/2014

Associated revisions

Revision cf2aba65
Added by Tobias Ellinghaus almost 5 years ago

Fix #10040: Support ICC profiles embedded in TIFFs

History

#1 Updated by Tobias Ellinghaus almost 5 years ago

  • Tracker changed from Bug to Feature
  • % Done changed from 0 to 20
  • Affected Version changed from 1.4.2 to git development version
  • System changed from Ubuntu to all
  • Category set to Darkroom
  • Status changed from New to Triaged

Currently we only read embedded profiles from JPEG and JPEG2000 files. In order to support it for TIFF we would need a sample file with a profile attached. It doesn't need to be big and the actual content doesn't matter (it should however be obvious if the profile was applied or not when looking at the image, so some saturation might be needed).

#2 Updated by Gert van der Plas almost 5 years ago

I've attached a zip file containing two jpegs and one tiff file generated by the Sony Image Data Converter. It has a included icc profile and the two included jpegs show the different saturation (particular the leaves) and some subtle weird color shifts in the shadows. The tiff should look like the proper jpeg in DT but looks like the improper jpeg. I did not include an epson scanner output. Let me know if you need one of them too. It takes a bit more time to get a 6x6 negative done.

Thanx.

#3 Updated by Tobias Ellinghaus almost 5 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

#4 Updated by Long Wei over 4 years ago

Does not seem to be fixed for epson profile.

See attached example and screenshot.
If I extract the ICC with extracticc from the file, place it in color/in and select from the list in the input color profil menu, it works (but I still have an error message on the screen)

#5 Updated by Roman Lebedev over 4 years ago

I see no screenshot, but that TIFF does add "embedded ICC profile" to "input color profile", selected by default, so i would assume that it is working fine.

#6 Updated by Long Wei over 4 years ago

Sorry, the screenshot was missing. The "embedded ICC profile" is indeed added to "input color profile" but the tones of the photos are not ok and there is a warning "warning unsupported input profile"

#7 Updated by Tobias Ellinghaus over 4 years ago

If you extract the profile ("EPSON Gray - Gamma 1.8") and select it manually it is also not supported. So it has nothing to do with using the embedded profile from TIFFs but the profile at hand.

#8 Updated by Long Wei over 4 years ago

I have a lot of TIFF with this epson profile in my collection and before the implementation of the feature #10040, darktable was working fine, profile was not managed and darktable was switching automatically to sRGB, whithout any warning.
But now, as the epson ICC is not recognize, there is a persistent warning on both darkroom mode and lightable mode in the middle of the screen and the profile is switched automatically to Linear Rec709 RGB which is very very different from the initial one.
I think it would make sense to keep the initial behaviour in case the profile is not supported -> switch to sRGB.

#9 Updated by Tobias Ellinghaus over 4 years ago

sRGB would be as wrong as linear Rec709. I will ask Pascal if we should change to sRGB in general, we will see.

#10 Updated by Roman Lebedev over 4 years ago

  • Related to Bug #10110: Darkroom mode hangs after adjusting tone curve when unsupported embedded ICC profile is used added

#11 Updated by Pascal de Bruijn over 4 years ago

Tobias is right, either Linear Rec709 or sRGB are both wrong, so a warning message is totally justified.

Supporting *Gray colorspace ICC profiles should be handled in a seperate feature request.

I've had a think about this, and if feasible I guess the following would probably be the least bad approach:

in case of RAW (when missing standard/enhanced matrix) -> Linear Rec2020 (not 709)
other cases -> sRGB

  • Gray colorspace ICC's apparently define a Gamma curve, white- & blackpoint, and no XYZ color matrix.

#12 Updated by Long Wei over 4 years ago

  • Copied to Feature #10112: Supporting *Gray colorspace ICC profiles (16 bit) added

Also available in: Atom PDF