Project

General

Profile

Bug #10005

Wrong mask position in certain cases

Added by Christian Mandel almost 4 years ago. Updated almost 4 years ago.

Status:
Incomplete
Priority:
Low
Category:
Masks
Target version:
-
Start date:
07/01/2014
Due date:
% Done:

20%

Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I had to edit a very low-res picture, where the default view is higher zoom than 100%. A circle shaped mask's effect (I tried to remove red eyes) shown in 200% view (due to the low resolution I had to draw there) took place in a distance to the mask “overlay”. The position of the effect and the overlay change with respect to the image's position in the view area. Checking at 100%, I think the effect's position is the right one and the overlay is wrong. It only hapens if the picture does not entirely fill the view area. See the attached screenshots for the effect.

2d_displacement.png - Screenshot showing 2D mask displacement (138 KB) Christian Mandel, 07/01/2014 10:15 PM

no_displacement.png - Screenshot showing no mask displacement (140 KB) Christian Mandel, 07/01/2014 10:16 PM

1d_displacement.png - Screenshot showing 1D mask displacement (138 KB) Christian Mandel, 07/01/2014 10:16 PM

darktable-mask-location.jpg.xmp (5.65 KB) Christian Mandel, 07/09/2014 11:41 AM

darktable-mask-location.jpg (22.5 KB) Christian Mandel, 07/09/2014 11:41 AM

darktablerc (15.5 KB) Christian Mandel, 07/12/2014 09:16 AM

History

#1 Updated by Ulrich Pegelow almost 4 years ago

  • Status changed from New to Incomplete
  • % Done changed from 0 to 20

I tried with darktable 1.4.1 and with our current development version but was not able to reproduce. In all cases overlay and mask effect were perfectly aligned.

#2 Updated by Ulrich Pegelow almost 4 years ago

Any further advice on how to reproduce the issue? If not I'll close the ticket in the next days.

#3 Updated by Christian Mandel almost 4 years ago

Can be that it is a 1.4.2 only problem and older as well as newer versions are not affected, but that seems unlikely to me. Therefore, I give some additional details and hope someone can reproduce it. I added an example image. My screen size is 1920x1080 which is equal to the maximum drawing area size in the config and 350 px wide sidebars.

Maybe it's not (only) mask related, since the drawing area that one can see in the screenshots does not correspond to the preview in the upper left. So if I go to 200% and drag the image to the lower right so that the upper left corner hits the border of the drawing area, it seems to toggle and a gray border pops in that is not visible in the preview. Only when that happens the mask position problem occurs.

Btw: usually it is not possible to have borders around the picture besides these that are necessary to compensate the difference between drawing area and image aspect ratios. The constellation that produces the wrong mask position seems therefore to be not intentional. In many cases it would be helpful if one could drag the picture beyond this limitation to draw mask points outside of the picture, e. g. to cover an object at the very border of the image. But I should do a feature request for that if it's not already there …

#4 Updated by Ulrich Pegelow almost 4 years ago

I guess there is really something broken with the center image display on your installation. Normally the center view should be centered symmetrically while in your case there is a big shift. I can't reproduce as I have a lower screen resolution (1680x1050).

I'd suggest that you try a new fresh configuration and see if this solves the problem. You can do so by calling

darktable --config-dir <xyz>

#5 Updated by Christian Mandel almost 4 years ago

A fresh configuration does not change this behavior nor does the smallest possible window I can reduce DT to (to be closer to your resolution). I even tried with removing ~/.config/darktable. Is there somebody with DT 1.4.2 around who could try?

#6 Updated by Tobias Ellinghaus almost 4 years ago

I can't open that file (darktable-mask-location.jpg), I only see a white image. Both in the browser as well as with display.

#7 Updated by Christian Mandel almost 4 years ago

Tobias Ellinghaus wrote:

I can't open that file (darktable-mask-location.jpg), I only see a white image. Both in the browser as well as with display.

That's because it is just a white image that I used for testing because you can clearly see the mask displacement as shown in the screenshot. I just added it for your convenience, together with an xmp file that contains an example mask. Just open the image and activate the curves to be shown in the activated module's drawn mask section. Then you should be able to reproduce the behavior (or not) by zooming into the corner to 200% (I used double middle klick if that makes a difference).

I don't believe that the problem is mask related anymore, it seems to come from the image displacement in the “drawing area”.

#8 Updated by Ulrich Pegelow almost 4 years ago

Could you please supply your darktablerc configuration file? Maybe we find a cause in there.

#9 Updated by Christian Mandel almost 4 years ago

Ulrich Pegelow wrote:

Could you please supply your darktablerc configuration file? Maybe we find a cause in there.

As I wrote, it happens even if I remove .config/darktable, so I attached a “fresh” config file generated by opening darktable once, opening the picture, activating the mask overlay (not the yellow one, I mean the one which you can move around and change node positions etc.) of the contrast/saturation/... plugin, middle mouse click to 200% (here the wrong position shows up) and then closing darktable.

#10 Updated by Ulrich Pegelow almost 4 years ago

Nothing obviously wrong in that config file.

I have not been able to reproduce the center view shift that you are observing, so there is nothing I can do at the moment.

This is the first report of that issue as far as I know - so it is probably only occuring under very specific conditions and might be system related. Best advice I can give is that you raise the topic in the darktable-users mailing list and see if someone else has similar issues.

#11 Updated by Roman Lebedev almost 4 years ago

  • System changed from Ubuntu to all
  • Affected Version changed from 1.4.2 to git development version

Ulrich Pegelow wrote:

Nothing obviously wrong in that config file.

I have not been able to reproduce the center view shift that you are observing, so there is nothing I can do at the moment.

This is the first report of that issue as far as I know - so it is probably only occuring under very specific conditions and might be system related. Best advice I can give is that you raise the topic in the darktable-users mailing list and see if someone else has similar issues.

I had that issue several times on different images.
Also, sometimes, with big zoom when i "zoom" (decrease) mask, it might occasionally jump away - completely change it's position.

Also available in: Atom PDF